Suggestions should hide already translated entities to avoid added translations to be overridden

Created on 9 September 2022, almost 2 years ago
Updated 20 May 2024, about 1 month ago

Problem/Motivation

While showing the suggestions for a translation job, tmgmt_content only checks the target source language and not for an already existing translation for the given target language of the translation job.
While adding entities to the job, that already have translations, we might end up in overriding existing translations or creating unneccessary revisions of already translated items.

Proposed resolution

We should also check for already existing translations in the target language before adding those entities to the suggestions.
Those suggestions should be hidden in the suggestions.

I'll attach a MR in this issue to fix the issue.

Further discussion

Maybe we should provide a setting to show/ hide existing translation or add a info message besides the entities, if a translation is available. This needs to be discussed.

✨ Feature request
Status

Needs review

Version

1.0

Component

User interface

Created by

πŸ‡©πŸ‡ͺGermany SteffenR Germany

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡¨πŸ‡­Switzerland miro_dietiker Switzerland

    Yes, i agree, in the most basic initial translation process, simply excluding them is great.

    However note that they can easily get outdated. And then they would need another translation cycle.
    TMGMT is not too helpful in supporting evolving items currently..

  • πŸ‡¨πŸ‡­Switzerland Berdir Switzerland

    Strongly considering to accept this without configuration options. We already ignore everything translated through TMGMT like this (anything that is in any kind of job, active or not).

    Might also include it in ✨ Suggestions for embedded entities Needs review and close this as duplicate as it will conflict, as that will cause the number of suggestions to explode for everyone using paragraphs with medias and similar references.

  • πŸ‡ͺπŸ‡ΈSpain ajFernandez

    Hello everyone.

    I am having the same problem in a project. I have applied the MR code in my project and can confirm that it works correctly.

    Perhaps, as @berdir comments, it would be more complete by adding some configuration setting in the module to enable this functionality, or perhaps even at the translation job level, to decide whether to apply this configuration individually in each translation job.

Production build 0.69.0 2024