- 🇦🇹Austria fago Vienna
ok, I took a look at this. First off, I made sure we have a good kernel test as base and ported over the existing functional tests to a kernel test. While I were there I also extended coverage for some things that had no coverage before, like redirect handling.
Then I also added the test for this and verified the core user-login-status json API still works with the module.
- @fago opened merge request.
- 🇸🇮Slovenia useernamee Ljubljana
Looks good. Most of assertions from functional tests are covered (and many new test cases are added, redirect and unsupported) in the new kernel test - I found one that's missing and I'm wondering if it is really needed (Overriding settings parameter is not allowed.).
- 🇦🇹Austria fago Vienna
thanks!
> Overriding settings parameter is not allowed
True. Thanks for spotting. I agree it's not important to test, the whole feature of enabling it via settings is quite obsolete, still supported, but this detail seems to be not important for it either, so I'm fine continuing without testing this.Thus, merged - thank you!