[PP-1] Compatibility with new `EntityInterface::[get|set]OriginalDefaultRevision()`

Thanks a lot for notifying me about this change. Let’s see if/when it will get merged in Core.

Updated method name to match the core patch. It's... close?

This has been merged now into core.

I updated setOriginal() directly in the merge request but didn't manually verify the definition is valid.

Thanks, berdir!
This will have to wait until we depend on Drupal 11.2, but great to have it ready for that already.

No it doesn't. This is a hard break on 11.2, but you can add it now, it's just an extra method that isn't actually there yet on the interface.

The problem is that search_api implements EntityInterface without extending from EntityBase, so new methods on the interface result in a fatal error.

This is a pattern copied from views module in core, I'm still not quite sure why it's necessary but would be nice to avoid doing that in the future I think, but that's out of scope, this is just about preparing for 11.2.

Ah, of course, sorry! I had just created 📌 Make use of the new EntityInterface::getOriginal() method Postponed for actually using the new methods (which of course needs the 11.2 dependency) so I was thinking about that when seeing this issue. But yes, we can and should of course fix that fatal error right away, thanks!

Now that I merged the latest HEAD into the fork the pipelines are also passing. So, merged.
Thanks again, everyone!

Come to think of it (a little late), we might also have made both methods throw a \RuntimeException since, logically, you shouldn’t ever pass or receive an UnsavedIndexConfiguration object in an entity update hook, so making this cause a fatal error might have actually been a better idea.
But probably not worth the additional effort now (or at all), should almost definitely be fine as-is.

Automatically closed - issue fixed for 2 weeks with no activity.