Created on 22 August 2022, over 2 years ago
Updated 3 February 2023, almost 2 years ago

Problem/Motivation

Codings standards aren't used in the project

Steps to reproduce

FILE: /app/www/modules/contrib/vitals/src/Controller/VitalsController.php
--------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------
143 | ERROR | [x] Data types in @throws tags need to be fully namespaced
145 | ERROR | [x] Data types in @throws tags need to be fully namespaced
--------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------

FILE: /app/www/modules/contrib/vitals/src/Form/VitalsAdminForm.php
----------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------
53 | ERROR | Class property $plugin_manager should use lowerCamel naming without underscores
----------------------------------------------------------------------------------------------

FILE: /app/www/modules/contrib/vitals/src/Vitals.php
--------------------------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------
30 | ERROR | [ ] Class property $plugin_manager should use lowerCamel naming without underscores
67 | ERROR | [x] Whitespace found at end of line
73 | ERROR | [x] Whitespace found at end of line
74 | ERROR | [x] Whitespace found at end of line
92 | ERROR | [x] Expected 1 blank line after function; 0 found
93 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 5 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------

FILE: /app/www/modules/contrib/vitals/src/VitalsCheckInterface.php
----------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
----------------------------------------------------------------------
20 | ERROR | [x] Whitespace found at end of line
21 | ERROR | [ ] Description for the @return value is missing
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /app/www/modules/contrib/vitals/vitals.install
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
40 | ERROR | [x] Expected 1 newline at end of file; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

FILE: /app/www/modules/contrib/vitals/tests/src/Functional/VitalsTest.php
-------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-------------------------------------------------------------------------
29 | ERROR | [ ] Missing member variable doc comment
85 | ERROR | [x] Expected 1 blank line after function; 2 found
131 | ERROR | [x] Line indented incorrectly; expected 6 spaces, found 7
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

FILE: /app/www/modules/contrib/vitals/.ci/config/settings.local.php
-------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------
4 | ERROR | [x] The second line in the file doc comment must be "@file"
-------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------

Time: 419ms; Memory: 12MB

Proposed resolution

Remaining tasks

/

User interface changes

/

API changes

/

Data model changes

πŸ“Œ Task
Status

Fixed

Version

2.2

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium stijnhau

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024