Automated Drupal 10 compatibility fixes

How far is this module from being ready for Drupal 10?

It's one of the last few modules that prevents our project to be upgraded to D10

How far is this module from being ready for Drupal 10?

According to upgrade_status module, there are still 8 issues to be resolved, even with the patch in #3.

2 of those are trivial setting of the version constraint, and 1 is simple setting of a theme in a test. The others will need more careful consideration.

CONTRIBUTED PROJECTS
--------------------------------------------------------------------------------
JSON:API Cross Bundles 8.x-1.0
Scanned on Tue, 30/05/2023 - 17:14.

8 warnings found.

modules/contrib/jsonapi_cross_bundles/src/Context/CrossBundleFieldResolver.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 14   │ Class                                                        │
│ manually │      │ Drupal\jsonapi_cross_bundles\Context\CrossBundleFieldResolve │
│          │      │ r extends @internal class                                    │
│          │      │ Drupal\jsonapi\Context\FieldResolver.                        │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/jsonapi_cross_bundles/src/ResourceType/CrossBundlesResourceType.
php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 10   │ Class                                                        │
│ manually │      │ Drupal\jsonapi_cross_bundles\ResourceType\CrossBundlesResour │
│          │      │ ceType extends @internal class                               │
│          │      │ Drupal\jsonapi\ResourceType\ResourceType.                    │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/jsonapi_cross_bundles/src/ResourceType/ResourceTypeRepositoryShi
m.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 14   │ Class                                                        │
│ manually │      │ Drupal\jsonapi_cross_bundles\ResourceType\ResourceTypeReposi │
│          │      │ toryShim extends @internal class                             │
│          │      │ Drupal\jsonapi\ResourceType\ResourceTypeRepository.          │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/jsonapi_cross_bundles/tests/src/Functional/CrossBundleCollection
Test.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                           MESSAGE                            │
├──────────┼──────┼──────────────────────────────────────────────────────────────┤
│ Check    │ 22   │ Drupal\Tests\BrowserTestBase::$defaultTheme is required. See │
│ manually │      │ https://www.drupal.org/node/3083055, which includes          │
│          │      │ recommendations on which theme to use.                       │
│          │      │                                                              │
└──────────┴──────┴──────────────────────────────────────────────────────────────┘

modules/contrib/jsonapi_cross_bundles/tests/src/Unit/Routing/Routing.php:
┌──────────┬──────┬──────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                         MESSAGE                          │
├──────────┼──────┼──────────────────────────────────────────────────────────┤
│ Check    │ 35   │ Call to deprecated method prophesize() of class          │
│ manually │      │ Drupal\Tests\jsonapi_cross_bundles\Unit\Routing\Routing: │
│          │      │ https://github.com/sebastianbergmann/phpunit/issues/4141 │
│          │      │                                                          │
│ Check    │ 37   │ Call to deprecated method prophesize() of class          │
│ manually │      │ Drupal\Tests\jsonapi_cross_bundles\Unit\Routing\Routing: │
│          │      │ https://github.com/sebastianbergmann/phpunit/issues/4141 │
│          │      │                                                          │
└──────────┴──────┴──────────────────────────────────────────────────────────┘

modules/contrib/jsonapi_cross_bundles/jsonapi_cross_bundles.info.yml:
┌──────────┬──────┬────────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                           │
├──────────┼──────┼────────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Value of core_version_requirement: ^8.7.7 || ^9 is not     │
│ manually │      │ compatible with the next major version of Drupal core. See │
│          │      │ https://drupal.org/node/3070687.                           │
│          │      │                                                            │
└──────────┴──────┴────────────────────────────────────────────────────────────┘

modules/contrib/jsonapi_cross_bundles/tests/modules/jsonapi_cross_bundles_test/j
sonapi_cross_bundles_test.info.yml:
┌──────────┬──────┬───────────────────────────────────────────────────────────┐
│  STATUS  │ LINE │                          MESSAGE                          │
├──────────┼──────┼───────────────────────────────────────────────────────────┤
│ Check    │ 0    │ Add core_version_requirement: ^9 || ^10 to designate that │
│ manually │      │ the extension is compatible with Drupal 10. See           │
│          │      │ https://drupal.org/node/3070687.                          │
│          │      │                                                           │
└──────────┴──────┴───────────────────────────────────────────────────────────┘

Following this conversation in Slack, it appears that the 3 warnings about extending @internal classes do not need addressing.

Also whilst prophesize() is deprecated, it is scheduled for removal in phpunit 10; Drupal 10 requires phpunit ^9.5, so this also shouldn't need fixing here.

So we basically just need to fix the version constraints and the default theme in the test.

New patch adding the steps outlined in [3304053#7]

Using a Merge Request as automated testing on the patch in #8 failed because the test harness couldn't use composer to build D10 with 8.x-1.x before patching because 8.x-1.x before patching isn't compatible with D10.

But now I can't see how to trigger the tests on a merge request.

I just fixed the default testing run, which was no longer supported. I think an empty commit will trigger a job run

Woo!

Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.