Honour 'Use the administration theme when editing or creating content' setting

Created on 16 August 2022, over 2 years ago
Updated 18 February 2023, almost 2 years ago

Problem/Motivation

It feels like a bit of an odd assumption that we would by default want to edit our paragraphs using the front end theme.

Don't misunderstand me here, I totally get why content editors might be very happy to use the front end theme but in many cases sites will be configured to use the standard Use the administration theme when editing or creating content setting from the Appearance page and thus we would expect the popup paragraph edit to appear using the admin theme.

Perhaps we should at least have the option set globally for all paragraph popup edits?

Feature request
Status

Closed: works as designed

Version

1.1

Component

Miscellaneous

Created by

🇬🇧United Kingdom SirClickALot Somerset

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇧🇷Brazil halth Brazil

    I see what @SirClickALot point is...

    When you're in the front-end of your website and click to edit a paragraph it renders the edit form using your FE theme, not the admin theme.

    I also found it odd when I first tried this module.

    This is something I would be happy to help with.

    Let's see if I can come up with a fix in the next few days.

  • Issue was unassigned.
  • Status changed to Closed: works as designed almost 2 years ago
  • 🇧🇷Brazil halth Brazil

    Okay, "sad" news.

    Unfortunately this is not possible for the own nature of how this feature was designed/built.

    The form that's rendered inside the modal is not contained inside an iframe (which would allow us to render it using the admin theme "in isolation"). Instead, it's rendered as part of the current page markup.

    Loading the admin theme's stylesheet alongside with the main FE theme's stylesheet would cause a direct conflict causing unpredictable issues.

    Creating a subset of the admin theme's stylesheet just to target this form rendered inside the modal would be a responsibility of the admin theme itself, since we cannot predict which admin theme the user is using.

    If anyone else sees a different way to accomplish this that would not require a severe rewrite of the module, I'm happy to know what it would be.

Production build 0.71.5 2024