- 🇺🇸United States davedg629
Agreed, but I think it should go a step further than just the "Enable" checkbox setting in the UI. As far as I can tell, Shield can be disabled in three ways:
1. Uncheck the "Enable Shield" box on the UI config page.
2. Disable Shield via settings.php: $config['shield.settings']['shield_enable'] = FALSE;
3. Set the Shield User to "null" in settings.php: $config['shield.settings']['credentials']['shield']['user'] = NULL; (this is according to Acquia's docs, I tried to use this method and it didn't work: https://docs.acquia.com/cloud-platform/arch/security/nonprod/)If the Shield module is disabled using any of the above methods, Acquia Purge should recognize that and not display the warning.
- Status changed to Needs review
over 1 year ago 10:43am 7 April 2023 - 🇮🇳India er.garg.karan Chandigarh
This is because the Acquia purge module checks if the shield module is installed and it has username in shield settings.
It should also check if shield is enabled via the "Enable Shield" checkbox or not.Was a quick fix. Sharing the patch.
The last submitted patch, 3: acquia-purge-recommendations-assumes-shield-is-active-3303739-3.patch, failed testing. View results →
-
japerry →
committed 254a72ed on 8.x-1.x authored by
er.garg.karan →
Issue #3303739 by er.garg.karan: Acquia Purge Recommendations assumes...
-
japerry →
committed 254a72ed on 8.x-1.x authored by
er.garg.karan →
- Status changed to Fixed
over 1 year ago 10:10pm 31 May 2023 - 🇺🇸United States japerry KVUO
That logic in the patch is correct, I think when this was originally made we didn't have those manual shutoff options. Anywho.. fixed!
Automatically closed - issue fixed for 2 weeks with no activity.