`Drupal.Commenting.FunctionComment.InvalidReturn` breaks on intersection return type annotations

Created on 14 August 2022, almost 2 years ago

Updated 28 April 2023, about 1 year ago

Problem/Motivation

The Drupal.Commenting.FunctionComment.InvalidReturn sniff apparently does not like union types in return values.

 19 | ERROR | [x] Expected "\Drupal\user\EntityOwnerInterface\Drupal\Core\Entity\ContentEntityInterface" but found "\Drupal\user\EntityOwnerInterface&\Drupal\Core\Entity\ContentEntityInterface" for function return
    |       |     type (Drupal.Commenting.FunctionComment.InvalidReturn)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Fixed

Version

8.3

Component

Coder Sniffer

Created by

🇺🇸United States bradjones1 Digital Nomad Life

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 1 year ago →

System Message

klausi → authored 5a1779e6 on 8.3.x

fix(FunctionComment): Fix support for PHP 8 intersection types (#3303625...

Status changed to Fixed about 1 year ago8:42am 28 April 2023
Comment about 1 year ago →
🇦🇹Austria klausi 🇦🇹 Vienna
Thanks for reporting, pushed a fix.

Copied the new regex from an upstream PHPCS pull request at https://github.com/squizlabs/PHP_CodeSniffer/pull/3459
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024