miniorange_saml_sp_issuer not set correctly when using "Upload Metadata URL"

Created on 12 August 2022, over 2 years ago
Updated 1 May 2024, 8 months ago

Problem/Motivation

On the "Service Provider Setup" page, if you enter a URL in the "Upload Metadata URL" field and click "Fetch Metadata", the
miniorange_saml_sp_issuer config value is set to $base_url in the upload_metadata() function. This should be set to this instead as it is in the submitForm() function:

  $sp_issuer = $base_url . '/samlassertion';

Steps to reproduce

  1. Go to the "Service Provider Setup" page.
  2. Enter a URL in the "Upload Metadata URL" field.
  3. Click "Fetch Metadata".

miniorange_saml_sp_issuer config value is set to "https://example.com" instead of "'https://example.com/samlassertion".

Proposed resolution

  1. Patch code to set miniorange_saml_sp_issuer config value correctly.
  2. Commit change.
πŸ› Bug report
Status

RTBC

Version

2.27

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jrb Raleigh-Durham Area, NC, USA

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024