- 🇧🇪Belgium msnassar
Patch from commit 6352b64 with the tests fixed... It is not possible to test MR!
- 🇧🇪Belgium msnassar
As we are in the process of migrating from group 1 to group 2, I would like to add this feature to group 2 & 3. But I would like to hear from the maintainers first?
I have 2 options:- Use the same concept as the patch in #5
- Use the same concept as the patch in #5 BUT move the method to AccessControlTrait:
public function getEntityStatusOperations() { if (!isset($this->parent)) { throw new \LogicException('Using AccessControlTrait without assigning a parent or overwriting the methods.'); } return $this->parent->getEntityStatusOperations(); }
And then, in the AccessControl:
public function getEntityStatusOperations() { return ['view']; }
Any other alternatives are very welcomed...
- 🇧🇪Belgium msnassar
Here is a proposed patch for group 2 and 3. It is different from what I proposed in #6.
I would like to hear from the maintainers whether this solution is acceptable. If yes, then I will add tests. - last update
over 1 year ago 9,628 pass