Links set to _parent or _top are set to that target value but without underscore

Created on 3 August 2022, over 2 years ago

Updated 13 February 2023, almost 2 years ago

Problem/Motivation

Links using the _top or _parent options get rendered in the output as target="parent" or target="top", i.e. they open in new windows with those literal names. They should presumably instead be using the specially reserved values, i.e. target="_parent" or target="_top". The _self and _blank options seem to work correctly.

(Unlike last issue I just filed, I haven't looked into when/where this might have gone wrong, except that it wasn't a regression from 1.3 to 1.4.)

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report

Status

Needs review

Version

1.4

Component

Code

Created by

🇺🇸United States maxstarkenburg Washington, DC

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇮🇳India satya.eedeti
Comment almost 2 years ago →
🇮🇳India satya.eedeti
Status changed to Needs review almost 2 years ago12:57pm 6 February 2023
Comment almost 2 years ago →
🇮🇳India satya.eedeti
Status changed to Needs work almost 2 years ago11:11pm 6 February 2023
Comment almost 2 years ago →
🇺🇦Ukraine ipinchuk
Hi @satya.eedeti,

Thanks for your patch. It works well for new entities, but not for already existing ones. I suggest adding an update function.

Thanks
First commit to issue fork.
@alexey_samsonov opened merge request.
Status changed to Needs review almost 2 years ago7:38am 13 February 2023
Comment almost 2 years ago →
🇧🇾Belarus Alexey_Samsonov

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024