We have a website with a multilingual setup, with moderation workflows and a constraint validator. So this might be an edge case which not many website will encounter. The validator checks if all content is translated before publishing, to prevent untranslated content showing up. In this setup it is not possible to publish a node when the social_media field is unchecked.
The root cause for this behavior is the isEmtpy() method in the SocialMediaItem.php FieldType file. In issue #2912202 a fix was added to the isEmpty() method, because the field was rendered without respecting the field value. The isEmpty() now checks for a value of 0. The value of 0 is a valid, non-empty value. It is the value of the field when not checked. The behavior of isEmpty() mimics the intended behavior, an 'empty' field will not render anything. But in our case it prevents nodes from being published, because the value of 0 will mark the field as 'empty' and therefor untranslated.
As stated before, the setup is probably not a common one. You will need:
- a multilingual website
- workflow moderation
- constraint validator to check if all content is translated before publishing
The constraint validator might contain code which has something like the following:
// Check if all translations have been created and published.
$translation_languages = $this->languageManager->getLanguages();
unset($translation_languages[$entity->language()->getId()]);
$translations_created = TRUE;
$translations_published = TRUE;
foreach ($translation_languages as $langcode => $language) {
if ($entity->hasTranslation($langcode)) {
$entity_translation = $entity->getTranslation($langcode);
if (!$entity_translation->isPublished()) {
// At least one translation has not yet been published.
$translations_published = FALSE;
}
}
else {
// At least one translation has not been created.
$translations_created = FALSE;
// What does not exist, cannot be published.
$translations_published = FALSE;
}
}
// If the entity is fully translated, and the translations are published,
// we are satisfied.
if ($translations_published) {
return;
}
To fix this issue the isEmpty() method should not check for a 0-value. Instead, the field formatter should check the value of the field and only when the value is 1 should the field be rendered.
I will attach a patch for this issue, which I've tested on our website. It is a small but logical change.
Postponed
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I feel that we need automated tests in place in order to apply the logic changes in here. Created https://www.drupal.org/project/social_media/issues/3359535 📌 Create automated tests for field/widget/formatters Active and I'm postponing this issue on #3359535.
I think these test cases will be fairly simple to implement (via Functional tests).
That being said, I've also re-targeted this against 2.0.x for a re-roll.