- 🇦🇺Australia fenstrat Australia
Thanks bot!
Attached makes a couple more changes, including the info file, injecting the url generator, and some test function returns.
- 🇦🇺Australia fenstrat Australia
Looks like our customised drupalci.yml is missing a couple changes from project_issue_file_test HEAD, bringing those in.
- 🇦🇺Australia fenstrat Australia
Looks like an odd nightwatch failure. We don't need that so lets try removing it.
-
fenstrat →
committed 5420649b on 2.x
Issue #3298006 by fenstrat, Project Update Bot: Automated Drupal 10...
-
fenstrat →
committed 5420649b on 2.x
- 🇦🇺Australia fenstrat Australia
Running branch tests on 10.0 shows up a D10 specific failure. CacheableJsonResponse::create has gone away in Symfony 6+ (D10 uses 6.2). So the attached should work in a way that's compatible with D9 and D10.
The last submitted patch, 10: 3298006-10.patch, failed testing. View results →
- Status changed to Needs work
about 2 years ago 3:06am 31 January 2023 - 🇦🇺Australia fenstrat Australia
D10 failure is because jQuery autocomplete has moved from core into contrib in D10: https://www.drupal.org/project/jquery_ui_autocomplete →
As that module is compatible with D9+ we should be able to require it in D9 now. This should allow us to keep the same 2.x branch for D9 and D10.
- Status changed to Needs review
about 2 years ago 3:06am 31 January 2023 - Status changed to Needs work
about 2 years ago 3:29am 31 January 2023 - 🇦🇺Australia fenstrat Australia
Actually the jquery_ui_autocomplete requirement could be disruptive for D9, so I'm going to revert this for the 2.x branch and spin up a new 3.x branch for D10.
-
fenstrat →
committed 956e2698 on 2.x
Revert "Issue #3298006 by fenstrat, Project Update Bot: Automated Drupal...
-
fenstrat →
committed 956e2698 on 2.x
- Status changed to Needs review
about 2 years ago 3:46am 31 January 2023 - 🇦🇺Australia fenstrat Australia
Now tests wont run till the core_version_requirement changes for adding 10 are in the branch, fun fun. Will commit and follow up if tests break.
-
fenstrat →
committed 94b85d43 on 3.x
Issue #3298006 by fenstrat, Project Update Bot: Automated Drupal 10...
-
fenstrat →
committed 94b85d43 on 3.x
- 🇦🇺Australia fenstrat Australia
Need to manually enable the requirements of jquery_ui_autocomplete as well, i.e. jquery_ui and jquery_ui_menu.
The last submitted patch, 20: 3298006-20.patch, failed testing. View results →
-
fenstrat →
committed 08af8962 on 3.x
Issue #3298006 by fenstrat: Drupal 10 jquery once fixes.
-
fenstrat →
committed 08af8962 on 3.x
- Status changed to Fixed
about 2 years ago 1:03am 2 February 2023 Automatically closed - issue fixed for 2 weeks with no activity.