- last update
9 months ago 21 pass - @mstenta opened merge request.
- last update
9 months ago 21 pass - Status changed to Needs review
9 months ago 2:19pm 6 October 2023 - πΊπΈUnited States m.stenta
The patches in #5, #6, #7 above did not apply for me, so I started fresh with
mglaman/phpstan-drupal
andpalantirnet/drupal-rector
.I opened a MR - let's see if the tests pass. I'm running into a strange test failure locally, which also happens on the
2.x
branch, so I think it may be related to the fact that I'm testing locally on PostgreSQL and not MariaDB. Fingers crossed that these pass... - last update
9 months ago 15 pass, 1 fail - Status changed to RTBC
9 months ago 3:01pm 6 October 2023 - πΊπΈUnited States m.stenta
I'm running into a strange test failure locally, which also happens on the 2.x branch, so I think it may be related to the fact that I'm testing locally on PostgreSQL and not MariaDB.
Ah ha! Confirmed. The drupal.org tests pass on MySQL but not on PostgreSQL. I'll have to look into that separately.
I think this is looking good though! I'm going to merge it into
2.x
.. - Status changed to Fixed
9 months ago 3:15pm 6 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.