- πΊπΈUnited States grgcrlsn321
Re-rolled patch#2 with check on null for strip_tags.
Deprecated function: strip_tags(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\addtocalendar\Plugin\Field\FieldFormatter\AddToCalendar->getProperValue() (line 233 of modules/contrib/addtocalendar/src/Plugin/Field/FieldFormatter/AddToCalendar.php).
- πΊπΈUnited States grgcrlsn321
Fixed my previous patch from comment #4.
- πΊπΈUnited States danflanagan8 St. Louis, US
I really like the updates made in #3. It would have been great to take that as the starting point for patches #4 and #6 instead of starting back at #2.
- πΊπΈUnited States danflanagan8 St. Louis, US
Here's a patch that starts with #3 and adds null coalesce operations to all the strip_tags calls to protect against null values.
- πΊπΈUnited States danflanagan8 St. Louis, US
When manually testing #8, I got an exception about not enough arguments being passed to AddToCalendarApiWidget::_construct()
I think we could add an empty update hook to rebuild the container, but I'd rather just add a simple BC Layout. That's what this patch does.
- Status changed to RTBC
over 1 year ago 3:49pm 15 May 2023 - πΊπΈUnited States attheshow
Patch #9 appears to be working well on our site.
- πΊπΈUnited States danflanagan8 St. Louis, US
I noticed I missed one BC layer in the patch in #9. This patch adds it.
-
danflanagan8 β
committed ff18cf0f on 8.x-3.x
Issue #3296530 by danflanagan8, grgcrlsn321, godotislate, attheshow:...
-
danflanagan8 β
committed ff18cf0f on 8.x-3.x
- Status changed to Fixed
over 1 year ago 7:27pm 22 May 2023 - πΊπΈUnited States danflanagan8 St. Louis, US
I just became a maintainer and was able to commit our patch! I'm going to do a quick final test before doing a D10-compatible release. Thanks!
- πΊπΈUnited States danflanagan8 St. Louis, US
Automatically closed - issue fixed for 2 weeks with no activity.