- π¦πΉAustria drunken monkey Vienna, Austria
Thanks for reporting this issue and already providing a patch! However, did the patch really work for you? I had to also override
acceptExposedInput()
to make this work as expected. (Or maybe you just tested it together with the Core patch? I generally like to avoid relying on Core fixes, where possible, since they take forever to get committed, and then it still takes a year or two until we can depend on the Drupal version the fix was committed to.)Attached is a re-roll of your patch, together with the necessary
acceptExposedInput()
change and test coverage.
Please give it a try or review if you get the chance!
And thanks again in any case! - last update
almost 2 years ago 539 pass - last update
almost 2 years ago 533 pass, 2 fail The last submitted patch, 4: 3296477-3--fix_date_between_filter_one_value--tests_only.patch, failed testing. View results β
- πΊπ¦Ukraine abramm Lutsk
Hi drunken monkey,
Sorry but that was year ago and I can't remember what project this was :). Also I've changed my computer since then and I don't get local projects copies from that time.
I think the patch worked (otherwise, why would I post it here) but there could be some other factors - like, maybe we had BEF there which affected this somehow or probably core patch like you've mentioned. In this case, it sounds reasonable to have this fixed at Search API side without needing core patch.Appreciate you finding about
acceptExposedInput()
and adding tests. I'll check if I can test the patch in nearest time. -
drunken monkey β
committed 53e59ba8 on 8.x-1.x authored by
abramm β
Issue #3296477 by abramm, drunken monkey: Fixed results when only one...
-
drunken monkey β
committed 53e59ba8 on 8.x-1.x authored by
abramm β
- π¦πΉAustria drunken monkey Vienna, Austria
Hi abramm,
No worries, completely my fault for being so much behind on my issue queues. As there is test coverage, I also donβt think itβs that concerning to not have this patch again verified by you. So, merged it.
Thanks again! - Status changed to Fixed
over 1 year ago 5:45pm 10 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.