- πΊπΈUnited States moonagedev
The method in #8 works for me. Thanks!
- π§πͺBelgium lobsterr
I need your opinion:
1) How useful it would be to have such settings per plugin. So, we can enable / disable it per group type ?
2) Or it is better keep it per invitations. For example on the form, we can have a checkbox "Accept invitation automatically" ? - πΊπΈUnited States jimmynash
Would it be possible to provide it as an option per group instance?
I can see a need for one group of the same type to use autoaccept while another wants to provide the second step after invite.
If a per instance group setting would be too difficult, I would vote for option 1 (autoaccept toggle per group type).
- Status changed to Needs review
over 1 year ago 11:23am 28 June 2023 - π©πͺGermany broon Potsdam
I've taken the approach from #8 and turned it into a patch for GInvite 3.0.0-beta3.
As for the question about making autoAccept an option, I would prefer an option per invitation, but make the default value (on/off) an option of the group instance.
- π§πͺBelgium lobsterr
1) I've added a new settings on the plugin. So, we can control it per group type and change it at any moment
2) Also, I've added a new event, when user login with invitations. In this case I check current invitations and accept them too. Also, this event could be useful for some other cases
3) I refactored a bit codeI will now continue to work on version for Group 2 and Group 3 based on #12
-
LOBsTerr β
committed 03db862c on 2.x authored by
broon β
Issue #3294710 by broon, jimmynash, LOBsTerr: Skip the invitation...
-
LOBsTerr β
committed 03db862c on 2.x authored by
broon β
-
LOBsTerr β
committed 0e575f89 on 3.0.x authored by
broon β
Issue #3294710 by broon, jimmynash, LOBsTerr: Skip the invitation...
-
LOBsTerr β
committed 0e575f89 on 3.0.x authored by
broon β
-
LOBsTerr β
committed 3782f57e on 4.0.x authored by
broon β
Issue #3294710 by broon, jimmynash, LOBsTerr: Skip the invitation...
-
LOBsTerr β
committed 3782f57e on 4.0.x authored by
broon β
-
LOBsTerr β
committed 50192d72 on 2.x
Issue #3294710 by LOBsTerr: Code improvements.
-
LOBsTerr β
committed 50192d72 on 2.x
-
LOBsTerr β
committed 35bcb76d on 3.0.x
Issue #3294710 by LOBsTerr: Code improvements.
-
LOBsTerr β
committed 35bcb76d on 3.0.x
- Status changed to Fixed
about 1 year ago 11:05pm 28 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.