- π©πͺGermany jurgenhaas Gottmadingen
Moving this to the new project which integrates ECA with Commerce.
- π©πͺGermany jurgenhaas Gottmadingen
Tagging for Drupal Dev Days next week.
- Assigned to czigor
- @czigor opened merge request.
- Status changed to Needs review
about 1 year ago 3:08pm 24 July 2023 - ππΊHungary czigor
Conditions where the config form features a commerce_entity_select form element (e.g.
Drupal\commerce_product\Plugin\Commerce\Condition\OrderProductType
, not sure if there's more) don't yet work with bpmn. Once this gets merged we need a followup issue for these.
- Status changed to Needs work
about 1 year ago 7:50am 27 July 2023 - π©πͺGermany jurgenhaas Gottmadingen
This is great work, thanks a lot @czigor for this contribution.
I've reviewed the code and left some suggestions; only minor stuff. But I haven't tested it.
- Status changed to Needs review
about 1 year ago 12:15pm 27 July 2023 - ππΊHungary czigor
Thanks for the review, fixed everything.
Little new to the merge request workflow... I tried to squash the commits, but they keep getting separated. Is this going to be fixed on merge?
- Status changed to Needs work
about 1 year ago 12:27pm 27 July 2023 - π©πͺGermany jurgenhaas Gottmadingen
Nice, thanks. Only one minor comment left. I wonder if anyone could also test this in a commerce installation? I don't have one around right now, but that would be important before we merge this.
@czigor no worries about the commits. While working on an MR it's actually quite handy to have access to each individual commit to follow the taken steps. When the MR gets merged, then we can optionally sqaush them.
- πΊπΈUnited States nicxvan
I'm planning on testing it today, thanks for the code review @jurgenhaas
-
nicxvan β
committed b889e75e on 1.0.x authored by
czigor β
Issue #3293930: Add support for commerce conditions
-
nicxvan β
committed b889e75e on 1.0.x authored by
czigor β
- Status changed to Fixed
about 1 year ago 1:22pm 27 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.