Automated Drupal 10 compatibility fixes

Thanks for posting these MRs, aurelianzaha! Could you please just close one of them, I don’t know why there are two identical ones.

Also, can you please explain the reason for the reordering of the ->accessCheck(FALSE) call?
Furthermore, I think if the previous method was assertObjectNotHasAttribute, then it should be replaced by assertFalse(property_exists(…)), not assertTrue(…).

Still, thanks for pointing out these necessary changes!

aurelianzaha → closed merge request !4

thanks @drunken-monkey for the feedback

the re-ordering ->accessCheck(FALSE) has the purpose to silent the errors created by https://www.drupal.org/project/upgrade_status → when checking the D10 compatibility of the module (see screenshot)
if you don't agree with those changes I can revert them

fixed the assert as well

drunken monkey → closed merge request !5

Thanks for explaining, that makes sense. (Though it does seem like a bug in the Update Status module, of course.) Then I have no problem with reordering the calls, especially in a test class. Thanks also for fixing the assertions.
Merged. Thanks again!

Back to Active, in case anything still comes up.

@drunken-monkey do you want maybe to make a new release that works width Drupal 10?

You’re right, thanks! Created an an Alpha 4 release → .

Since Drupal 10 is out now and I think we are compatible I think we can mark this issue “fixed”.
Thanks again to everyone who helped!

Automatically closed - issue fixed for 2 weeks with no activity.