Automated Drupal 10 compatibility fixes

Open on Drupal.org →

Created on 15 June 2022, over 2 years ago

Updated 3 March 2023, almost 2 years ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Periodically patches will be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted simply close this issue (any status besides Active, Needs review or Needs work) or remove the "ProjectUpdateBotD10" tag from the issue.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

Accept automated patches until this issue is closed
If this issue is left open (status of Active, Needs review or Needs work) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.
Leave open but stop new automated patches.
If you want to use this issue as a starting point to remove deprecated API uses but don't want new automated patches simply leave this issue open but remove the "ProjectUpdateBotD10" tag from the issue.

You can use Drupal Rector yourself to make these patches.

If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.
Close it and don't use it
If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review or Needs work) and no more automated patches will be posted here.

If the issue is reopened, then new automated patches will be posted.

If you are using another issue(s) to work on Drupal 10 compatibility it may be useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

Apply the patch in the comment by Project Update Bot → .
Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Infrastructure project issue queue → using the component “Bot: Drupal Rector”.

📌 Task

Status

Fixed

Version

1.0

Component

Code

Created by

project update bot

Live updates comments and jobs are added and updated live.

Drupal 10 compatibility

ProjectUpdateBotD10

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇫🇮Finland merilainen
What about problems like
Call to deprecated function file_create_url(). Deprecated in drupal:9.3.0 and is removed from drupal:10.0.0. Use the appropriate method on \Drupal\Core\File\FileUrlGeneratorInterface instead.
Comment almost 2 years ago →
🇺🇸United States solotandem
What code (core, this module) are you running that generated this 'problem'? The code in 8.x-1.6 release of this module checks for the 'file_url_generator' service available in drupal 10. if present it uses that, otherwise it calls file_create_url() which exists prior to 10. How can the 'problem' you mention exist if you are using compatible code?
Comment almost 2 years ago →
🇫🇮Finland merilainen
Yep, I didn't check the code, I just saw the problem reported by upgrade_status, sorry. This makes it harder to see which projects are actually ready for D10 because I need to manually go through each problem reported by upgrade_status and see if they are false negatives or real problems.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024