- 🇩🇪Germany mvogel
I have successfully upgraded to Drupal 10 using the following patch. However, it is important to note that all custom code must be updated to comply with the new event dispatcher standards, including the proper order of event objects and event names. Additionally, we must ensure that the declaration of Drupal\event_scheduler\EventSchedulerDispatcher is compatible with Symfony\Contracts\EventDispatcher\EventDispatcherInterface to get the page running. While there may be alternative methods, this approach has worked well for our test site. I will be able to provide more information on the effectiveness of this approach by the end of February when we push it to production.
- 🇩🇪Germany ro-no-lo
Hi,
I already updated the code to a version 3.x.x because it changed that much, but the Drupal gut system prevents me of signing in or something. It is really frustrating. I might try it again. It was something with a git repo token or so, which was not linking to the position were I can setup that. I do have one for another project here on drupal.org, but somehow the drupalgit is bossing me around for something it misses.
Sorry for that.
- 🇩🇪Germany mvogel
After reviewing I found some points
- Declaration of EventSchedulerDispatcher::dispatch still does not match the declaration from Symfony\Contracts\EventDispatcher\EventDispatcherInterface because the return type has to be
object
instead of?Event
- The function in event subscriber EventsProcessSubscriber
public function onKernelTerminate(Event $event): void
can not use Event as the parameter, it has to be TerminateEvent but we can drop the argument because it is not used - In the
public function setPageSent()
inEventSchedulerDispatcher
you have on->dispatch()
call where we have to swap event name and event parameter
- Declaration of EventSchedulerDispatcher::dispatch still does not match the declaration from Symfony\Contracts\EventDispatcher\EventDispatcherInterface because the return type has to be
- @mvogel opened merge request.