Contrib.social

Automated Drupal 10 compatibility fixes

Open on Drupal.org →
Created on 15 June 2022, over 2 years ago
Updated 8 February 2023, almost 2 years ago

Problem/Motivation

Hello project maintainers,

This is an automated issue to help make this module compatible with Drupal 10.

To read more about this effort by the Drupal Association, please read: The project update bot is being refreshed to support Drupal 10 readiness of contributed projects →

Patches will periodically be added to this issue that remove Drupal 10 deprecated API uses. To stop further patches from being posted, change the status to anything other than Active, Needs review, Needs work or Reviewed and tested by the community. Alternatively, you can remove the "ProjectUpdateBotD10" tag from the issue to stop the bot from posting updates.

The patches will be posted by the Project Update Bot → official user account. This account will not receive any issue credit contributions for itself or any company.

Proposed resolution

You have a few options for how to use this issue:

  1. Accept automated patches until this issue is closed

    If this issue is left open (status of Active, Needs review, Needs work or Reviewed and tested by the community) and the "ProjectUpdateBotD10" tag is left on this issue, new patches will be posted periodically if new deprecation fixes are needed.

    As the Drupal Rector project improves and is able to fix more deprecated API uses, the patches posted here will cover more of the deprecated API uses in the module.

    Patches and/or merge requests posted by others are ignored by the bot, and general human interactions in the issue do not stop the bot from posting updates, so feel free to use this issue to refine bot patches. The bot will still post new patches then if there is a change in the new generated patch compared to the patch that the bot posted last. Those changes are then up to humans to integrate.

  2. Leave open but stop new automated patches.

    If you want to use this issue as a starting point to remove deprecated API uses but then don't want new automated patches, remove the "ProjectUpdateBotD10" tag from the issue and use it like any other issue (the status does not matter then). If you want to receive automated patches again, add back the "ProjectUpdateBotD10" tag.

  3. Close it and don't use it

    If the maintainers of this project don't find this issue useful, they can close this issue (any status besides Active, Needs review, Needs work and Reviewed and tested by the community) and no more automated patches will be posted here.

    If the issue is reopened, then new automated patches will be posted.

    If you are using another issue(s) to work on Drupal 10 compatibility it would be very useful to other contributors to add those issues as "Related issues" when closing this issue.

Remaining tasks

Using the patches

  1. Apply the latest patch in the comments by Project Update Bot → or human contributors that made it better.
  2. Thoroughly test the patch. These patches are automatically generated so they haven't been tested manually or automatically.
  3. Provide feedback about how the testing went. If you can improve the patch, post an updated patch here.

Providing feedback

If there are problems with one of the patches posted by the Project Update Bot → , such as it does not correctly replace a deprecation, you can file an issue in the Drupal Rector issue queue → . For other issues with the bot, for instance if the issue summary created by the bot is unclear, use the Project analysis issue queue → .

📌 Task
Status

Fixed

Version

4.0

Component

Code

Created by

Project Update Bot

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment almost 2 years ago →
    System Message
  • Comment almost 2 years ago →
    🇨🇭Switzerland berdir Switzerland
    1. +++ b/bynder.module
@@ -263,5 +263,16 @@ function bynder_ckeditor_css_alter(array &$css, Editor $editor) {
+/**
+ * Implements hook_library_info_alter().
+ */
+function bynder_library_info_alter(&$libraries, $extension) {
+  if ($extension == 'bynder' && isset($libraries['formatter'])) {
+    if (\Drupal::moduleHandler()->moduleExists('jquery_ui_tooltip')) {
+      $libraries['formatter']['dependencies'][] = 'jquery_ui_tooltip/tooltip';
+    }
+  }

      this is no longer needed. 

    2. +++ b/composer.json
@@ -1,18 +1,17 @@
   "suggest": {
+    "drupal/jquery_ui_tooltip": "Adds a nicer tooltip.",
     "drupal/entity_usage": "Required for the optional submodule bynder_usage to track bynder media usage (entity_usage 8.x-2.x)",
     "drupal/dropzonejs": "Will help provide an 'Upload to Bynder' entity browser plugin."
   }

      nor this.

    Removed on commit.

  • Status changed to Needs review almost 2 years ago
  • Comment almost 2 years ago →
    🇺🇸United States dave reid Nebraska USA

    FYI this change just declared all the sub-modules incompatible with Drupal 9:

    diff --git a/modules/bynder_sns/bynder_sns.info.yml b/modules/bynder_sns/bynder_sns.info.yml
index 0634af4..5520b93 100644
--- a/modules/bynder_sns/bynder_sns.info.yml
+++ b/modules/bynder_sns/bynder_sns.info.yml
@@ -2,7 +2,7 @@ name: Bynder SNS
 description: 'Supports asset updates through Amazon SNS notifications'
 type: module
 package: Media
-core_version_requirement: ^8.7.7 || ^9
+core_version_requirement: ^8.7.7 || ^10
 
 dependencies:
   - bynder:bynder
diff --git a/modules/bynder_usage/bynder_usage.info.yml b/modules/bynder_usage/bynder_usage.info.yml
index afc052f..3160a58 100644
--- a/modules/bynder_usage/bynder_usage.info.yml
+++ b/modules/bynder_usage/bynder_usage.info.yml
@@ -2,7 +2,7 @@ name: Bynder Usage
 description: 'Reports usage tracking of media items back to the Bynder API'
 type: module
 package: Media
-core_version_requirement: ^8.8 || ^9
+core_version_requirement: ^8.8 || ^10
 
 dependencies:
   - bynder:bynder
diff --git a/modules/demo/bynder_demo.info.yml b/modules/demo/bynder_demo.info.yml
index 3fe0831..82631f0 100644
--- a/modules/demo/bynder_demo.info.yml
+++ b/modules/demo/bynder_demo.info.yml
@@ -2,7 +2,7 @@ name: Bynder Demo
 description: 'Demonstration of the Bynder integration.'
 type: module
 package: Media
-core_version_requirement: ^8.8 || ^9
+core_version_requirement: ^8.8 || ^10
  • Comment almost 2 years ago →
    🇺🇸United States dave reid Nebraska USA

    Wrong patch sigh.

  • Comment almost 2 years ago →
    🇺🇸United States dave reid Nebraska USA

    Upgrading to critical as this prevents several of the modules from working or being enabled on Drupal 9 anymore.

  • Comment almost 2 years ago →
    System Message
  • Status changed to Fixed almost 2 years ago
  • Comment almost 2 years ago →
    🇨🇭Switzerland berdir Switzerland

    That's very weird, no idea how I missed, that, fixed. Thanks for noticing just in time.

    If you were on dev then I guess you already noticed the problem with the jquery_ui_tooltip dependency that composer might remove if you don't depend on it otherwise. I'll add some notes about that to the release.

  • Comment over 1 year ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Comment about 1 year ago →
    🇷🇴Romania mihai_brb

    The Bynder formatter library depends on core/popperjs
    However this has been deprecated
    The popperjs asset library is deprecated in Drupal 9.5.0 and will be removed in Drupal 10.0.0. There is no replacement. See https://www.drupal.org/node/3307518 →

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024