\Drupal calls should be avoided in classes, use dependency injection instead

Created on 14 June 2022, over 2 years ago

Updated 20 May 2024, 6 months ago

$ phpcs --standard=Drupalpractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml advanced_pwa/

FILE: C:\xampp\htdocs\contribution\web\modules\contrib\advanced_pwa\src\Form\AdvancedpwaForm.php
------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------
100 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
154 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------

FILE: C:\xampp\htdocs\contribution\web\modules\contrib\advanced_pwa\src\Form\ManifestConfigurationForm.php
----------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
170 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
----------------------------------------------------------------------------------------------------------

📌 Task

Status

Closed: duplicate

Version

1.0

Component

Code

Created by

🇮🇳India Rakhi Soni

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 8 months ago →
System Message

gMaximus → committed b06a9da9 on 8.x-1.x
Issue #3285580 by dipesh_goswami, Rakhi Soni: \Drupal calls should be...
Comment 8 months ago →
System Message
gMaximus → closed merge request !4
Status changed to Closed: duplicate 6 months ago3:21pm 20 May 2024
Comment 6 months ago →
🇬🇧United Kingdom gMaximus
This caused errors when saving the push notifications settings page. There are a few reports of the dependency injection. I'm closing this to focus efforts in one place.

Your help would be appreciated.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024