- Merge request !137Issue #3283922 by cmlara: TfaSetupForm overrides form_state storage → (Open) created by cmlara
Currently in BasicSetup buildForm() the setup code will obtain the storage early on, make modifications, and force the storage to be saved with setStorage() which overwrites any data that may have been input. This prevents passing data through the form API. Many modules appear to use the tempstore.private service as an alternative, though on an initial glance I would expect this could lead to data inconsistency if a user were to load the form in multiple browser tabs before choosing to submit a form.
Additionally submitForm() and tfaNextSetupStep() also have calls to setStorage() though these may be less obstructing.
Review BasicSetup.php
Convert to setting the values while merging in any changes made inside plugin forms.
Write patch.
None
Form state will be adjustable from inside plugins.
None
Active
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.