Image link is mapped incorrectly

We're running into a similar issue. No updates on how we manage to handle it.

Merge request opened:

https://git.drupalcode.org/project/feeds/-/merge_requests/137

If anyone needs a patch:

https://git.drupalcode.org/project/feeds/-/merge_requests/137.patch

Explanation and disclaimer

Please know this only a workaround and I don't truly expect this to be merged. It does not get at the true source of the issue. But let me explain what this workaround does.

I can only speak from our experience. This can happen when you have multiple feed types with multiple feeds and they all update one content type. It's certainly possible this bug occurs under other circumstances, but this is ours.

Removing this if statement from \Drupal\feeds\Laminas\Extension\Mediarss\Entry::getMediaElement will work around the issue:

    if (array_key_exists($media_key, $this->data)) {
      return $this->data[$media_key];
    }

This is because if you are importing multiple feeds at once either by running cron or by running drush feeds:import-all (although I have seen this happen more consistently when triggered by cron), and a feed has already imported that has <media:content /> data, when the next feed is imported that also has <media:content /> data, $this->data can contain stale/incorrect data from the previous feed. Removing the if statement forces the media:content url to parsed/retrieved from the feed.

Why $this->data contains stale data is a larger issue. I've tried to understand it but I can't. I think it has to do with \Drupal\feeds\Feeds\Parser\SyndicationParser::parse and the way $entry is instantiated within the foreach loop (currently starting at line 94). It is not clear to me what class $entry is or how the current code even works.

Within the foreach loop, $entry may be one of these classes:

• \Drupal\feeds\Laminas\Extension\Mediarss\Entry
• \Laminas\Feed\Reader\Feed\Rss
• \Laminas\Feed\Reader\Entry\Rss

It seems to me that \Drupal\feeds\Laminas\Extension\Mediarss\Entry should extend \Laminas\Feed\Reader\Feed\Rss instead of \Laminas\Feed\Reader\Feed\AbstractFeed. I say this because there are no issues with stale/incorrect data for the methods on \Laminas\Feed\Reader\Feed\Rss such as \Laminas\Feed\Reader\Feed\Rss::getTitle.

#3316065: Images imported from external feed often map to the incorrect node entity when several feeds are imported during the same cron run → looks like a duplicate of this one. For now I'm just linking it as a related issue.

This needs a test to demonstrate what is exactly going wrong. After that, we can work out what the correct way is to fix it.