ColorboxCommands::__construct should type against interface

TypeError: Drupal\colorbox\Commands\ColorboxCommands::__construct(): Argument #1 ($library_discovery) must be of type Drupal\Core\Asset\libraryDiscovery, Drupal\attachinline\Asset\LibraryDiscoveryDecorator given, called in /app/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 262 in Drupal\colorbox\Commands\ColorboxCommands->__construct() (line 34 of /app/web/modules/contrib/colorbox/src/Commands/ColorboxCommands.php).

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇺🇸United States bburg Washington D.C.
The 2.0.0 version of the Colorbox module was released shortly after the last MR in #9, and the patch no longer applies cleanly to the 2.0.x branch. I don't know how to create a second merge request in the same issue (or if it's at all possible, so maybe this would require a new issue?). Attached is a patch for the 2.0.x version.

Can this be merged soon? Missing this patch makes using modules like https://www.drupal.org/project/colorbox_inline → kick up errors immediately when trying to do anything.
Comment almost 2 years ago →
System Message

paulmckibben → committed 767ed200 on 2.0.x authored by bburg →
Issue #3280948 by jsricardo, gapple, ramonvasconcelos, bburg, alexanderj...
Status changed to Fixed almost 2 years ago8:05pm 7 June 2023
Comment almost 2 years ago →
🇺🇸United States paulmckibben Atlanta, GA
Thanks for the patch and reviews, everyone!
Comment almost 2 years ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

ColorboxCommands::__construct should type against interface

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments & Activities