Fix our Tour integration

Created on 17 May 2022, over 2 years ago
Updated 11 August 2024, 5 months ago

Checking our Tour integration by pure coincidence showed me that it is in fact not even working anymore, at least on the Fields page. Apparently, we use the :nth() CSS selector which is not supported (anymore), as tour.js uses document.querySelector() instead of jQuery() for selecting elements for some reason. (I highly suspect this was changed at some point, otherwise our integration would never have worked.)

However, while we’re at it, there might also be some tips we want to add or update, given that they are now over five years old. So, should probably go over all the tours again and look for things to improve.

Finally, to ensure this doesn’t break again, we might want test coverage for this?

🐛 Bug report
Status

Needs work

Version

1.0

Component

General code

Created by

🇦🇹Austria drunken monkey Vienna, Austria

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇦🇹Austria drunken monkey Vienna, Austria

    Side note: Tour is now not part of Core anymore, so not that critical to support. Still, since we already have the tours, would be good to get them fixed. Not sure we need test coverage, though. Also depends on how popular the contrib module will prove to be.

Production build 0.71.5 2024