- πΊπΈUnited States ultimike Florida, USA
I worked on this with one of my students, @notsosolo, as an exercise. We ended up not only adding summary text for "Strip HTML", but also for "Honor a zero trim length" and "Replace tokens before trimming". In addition, we cleaned up some (most) of the code in the
settingsSummary()
method.Work here is not yet complete, as test coverage is needed.
-mike
- @ultimike opened merge request.
- Status changed to Needs review
about 1 year ago 1:56pm 28 March 2023 - πΊπΈUnited States ultimike Florida, USA
Functional test created. Ready for review.
-mike
- @ultimike opened merge request.
- πΊπΈUnited States ultimike Florida, USA
Hrm - anyone know how to get the testbot to test !32 and not !31?
-mike
- @ultimike opened merge request.
- πΊπΈUnited States ultimike Florida, USA
Going the patch route...
-mike
-
ultimike β
committed da3f9672 on 2.0.x
Issue #3278150 by ultimike: "Strip HTML" formatter option improvements
-
ultimike β
committed da3f9672 on 2.0.x
- Status changed to Fixed
about 1 year ago 6:54am 30 March 2023 - πΊπΈUnited States ultimike Florida, USA
After making a HUGE mess in this issue with MRs, I decided to go the patch route (comment 10) in order to see that sweet, sweet green testbot pass.
I've committed this change.
Let us never speak of this fumbling around with MRs again.
-mike
Automatically closed - issue fixed for 2 weeks with no activity.