- last update
over 1 year ago 6 pass - π¦πΊAustralia alex.skrypnyk Melbourne
Re-roll against latest released version (#6 does not apply) 7.x-2.35
- Status changed to Needs work
over 1 year ago 11:34am 4 May 2023 - π§π·Brazil thalles TeΓ³filo Otoni - MG
@joelpittet, can you send us a patch with jShrink new version?
- πΈπ°Slovakia poker10
Thanks for working on this!
Unless we want to intentionally drop support for PHP < 5.6, I think I would prefer the simple fix in #6 (see the comment #10). I am also not sure if someone will be able to provide the more complicated patch as suggested by #8 in this D7 phase.
- πΊπ¦Ukraine init90 Ukraine
In my case, it leads to server lagging and interaction of site works. I've increased priority to higher.
The patch from #16 fixed the problem.
- Status changed to RTBC
5 months ago 4:46am 26 June 2024 - πΊπΈUnited States hargobind Austin, Texas
#16 works for my sites as well.
Since this issue priority is Major, marking RTBC unless @poker10 or other maintainers have something to say about it.
The commit in #16 can go in now, and then someone can work on the backport for jShrink at a later date if it's still important.
-
poker10 β
committed 0566d5d7 on 7.x-2.x
Issue #3277342 by alan-ps, asghar, Dmitrii_Zadorozhnyi, alex.skrypnyk,...
-
poker10 β
committed 0566d5d7 on 7.x-2.x
- Status changed to Fixed
5 months ago 9:55pm 8 July 2024 - πΈπ°Slovakia poker10
Even though there is a workaround mentioned in #3252394-31: JShrink incompatible with PHP 8 β , I think that it is worth fixing this as it is a small fix.
For others needing a newer jShrink, please check the approach mentioned in the comment #31 on the link above.
Committed and pushed this to 7.x-2.x, thanks!
Automatically closed - issue fixed for 2 weeks with no activity.