Introduced by 🐛 PHP 8.1 EasyBreadcrumbBuilder::normalizeText deprecation Fixed .
The language construct empty() is a dangerous animal...
Very few users will hit this, but the handling of "0" was changed, and the change looks incorrect.
If the NULL case must be handled, better to handle that and nothing else. I suggest using the comparison operator and doing a strict check for NULL. If "0" and FALSE need to be handled as well, then a DocBlock comment would help. Actually, docs on the NULL handling might help, too. What does it mean if NULL is passed? Is that a normal case or could it indicate a bug elsewhere? Should the next major version throw an exception on NULL or FALSE? (manually or by type declaration usage.)
Needs work
2.0
Code
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
This seems to be valid Issue... not only in the normalizer but we are also doing a lots of test against $title using empty