Filter missing when using the add above button dialog

Created on 12 April 2022, over 2 years ago
Updated 1 August 2023, over 1 year ago

Problem/Motivation

Filter does not display when using the Add Above button to add paragraphs to a node (see attached images, noting the absence of the filter in the one for the add above button and its presence for the standard Add Paragraph button). This leads to user headaches when many paragraph types are defined, as they cannot easily search for what they need.

The cause appears to be that the wrong class is used in the click handler called by paragraphsAddAboveButton in paragraphs.add_above_button.js in the Paragraphs module. Changing this brings the filter back (see the attached .patch file).

Steps to reproduce

  1. Have some paragraph types ready.
  2. Create a node (for instance, an article).
  3. Add paragraphs to the node with both the normal button and the add above button. This should show the correct modal in both cases.

Proposed resolution

Adding clones of the relevant JavaScript functions to override the Paragraph module's functions. See the attached patch for details. This needs review.

Remaining tasks

Patch needs review.

User interface changes

This would bring back a functional filter, and let the user search among components.

🐛 Bug report
Status

Closed: cannot reproduce

Version

2.1

Component

User interface

Created by

🇫🇮Finland pontus.talvikarhu

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024