- πΊπΈUnited States kerasai
Hi there,
I've done a cursory review, and this seems mostly fine.
The one thing I've noticed, is that you've added the
LICENSE.txt
and changes to the module's.info.yml
file. These are added to the Composer package/download automatically by Drupal's package handling system and shouldn't be included in the module's repo.Otherwise, it's probably good to merge.
Thanks!
-
jfurnas β
committed 924eabb9 on 1.0.x
Issue #3274298: Make the trigger type a configurable option
-
jfurnas β
committed 924eabb9 on 1.0.x
- πΊπΈUnited States jfurnas
All set. The licensing and *.info.yml information has been removed.
- Status changed to Fixed
over 1 year ago 8:22pm 20 July 2023 Automatically closed - issue fixed for 2 weeks with no activity.