Fix Slick Selector on Local Video JS to be More Specific for Varbase Hero Slider Slick

Created on 6 April 2022, over 2 years ago
Updated 12 September 2023, about 1 year ago

Problem/Motivation

If we add the varbase hero slider on the page and the same page we add another slick slider,
the code in video.heroslider.local.js it's more general and this will affect all sliders on the page for ex:($(".slick__slider").slick("slickPlay");)

Steps to reproduce

Add Varbase hero slider with local video on a page, and add another slick slider.

Proposed resolution

Make the selector more specific for varbase heroslider slick.

Remaining tasks

  • ✅ File an issue about this project
  • ❌ Addition/Change/Update/Fix to this project
  • ❌ Testing to ensure no regression
  • ❌ Automated unit/functional testing coverage
  • ❌ Developer Documentation support on feature change/addition
  • ❌ User Guide Documentation support on feature change/addition
  • ❌ Accessibility and Readability
  • ❌ Code review from 1 Varbase core team member
  • ❌ Full testing and approval
  • ❌ Credit contributors
  • ❌ Review with the product owner
  • ❌ Update Release Notes and Update Helper on new feature change/addition
  • ❌ Release

Varbase update type

  • ✅ No Update
  • ➖ Optional Update
  • ➖ Forced Update
  • ➖ Forced Update if Unchanged

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • N/A
🐛 Bug report
Status

Closed: duplicate

Version

9.0

Component

Code

Created by

🇯🇴Jordan Qusai Taha Amman

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024