Token Entity Types Performance

Created on 23 March 2022, about 3 years ago

Updated 10 August 2024, 8 months ago

Problem/Motivation

Currently the function _votingapi_tokens_get_entity_types() Uses a SELECT DISTINCT entity_type FROM {votingapi_vote} query to get entity types. There can be thousands of rows in this database table. Selecting the entity types in this fashion is not very performant.

Proposed resolution

Create a configuration form for the votingapi_token module and pull the entity types from the configuration instead of the database.

✨ Feature request

Status

Needs work

Version

4.0

Component

Code

Created by

🇺🇸United States saltwaterskin

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!57Token Entity Types Performance
Open
🇺🇸United States tr
updated about 1 month ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 8 months ago →
🇺🇸United States tr Cascadia
Comment about 1 month ago →
🇺🇸United States tr Cascadia
I re-rolled the patch for 4.0.x and put it into an MR for testing.
Merge request !57Issue #3271260 by saltwaterskin: Token Entity Types Performance → (Open) created by tr
Comment about 1 month ago →
🇺🇸United States tr Cascadia
The existing test fail with these changes because the tests were not changed to accommodate the alterations made by the MR.

Also, there are a bunch of phpcs errors because method parameters are not documented.

Both these things need to be fixed before we can progress on this issue.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

Token Entity Types Performance

Problem/Motivation

Proposed resolution

Merge Requests

!57Token Entity Types PerformanceOpen

Comments & Activities

!57Token Entity Types Performance
Open