'Suffix' should not be used for affiliations

Created on 17 March 2022, over 2 years ago
Updated 27 April 2022, over 2 years ago

Problem/Motivation

The CrossrefContributorNormalizer currently iterates through all affiliations, imploding them and putting them wholesale into the 'suffix' field. This is inappropriate use of the data and will cause an error if the affiliation list is too long for the suffix field.

Steps to reproduce

Attempt to import a reference that has an author with multiple/long affiliations ( 10.1029/2021JD035198 is my working example ). Try to save the form. It will produce an error; the value is too long for the 'suffix' field in the database.

Proposed resolution

Suffix is a short field meant for name suffixes (e.g. 'Jr'). Affiliation has no proper place currently in the Contributor entity. Either create a new/custom one for the affiliation, or skip altogether.

(Personally I will be using a patch to omit lines 34-40 of CrossrefContributorNormalizer.php .)

πŸ› Bug report
Status

Active

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States tlwatson

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

No activities found.

Production build 0.71.5 2024