- First commit to issue fork.
- last update
over 1 year ago 36 pass - @admirlju opened merge request.
- Status changed to Needs review
over 1 year ago 1:20pm 10 August 2023 Added a new select for Workspaces, by default it selects all workspaces after selecting a specific workspace it filters the page select.
- last update
over 1 year ago 36 pass - First commit to issue fork.
- last update
over 1 year ago 36 pass - First commit to issue fork.
- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago 35 pass, 2 fail - last update
over 1 year ago 35 pass, 2 fail - last update
over 1 year ago 35 pass, 2 fail - last update
over 1 year ago 36 pass - 🇸🇮Slovenia deaom
When you switch between workplaces and there is no pages/subpages added, you get an empty select instead of the default "- Select - " option displayed as when the options are replaced that first "- Select- " option is removed. The same happens when you go back to "main" all workplaces select, the default "- Select -" option is removed. Changed that, and also updated the coding standards and test, so leaving it to needs review.
- last update
over 1 year ago 36 pass - 🇸🇮Slovenia bcizej
New configuration was added to schema for subpages but there was no default value set for that in
config/instapage.pages.yml
. The files was not in correct folder anyway so moved it toconfig/install
folder and added an update hook to update the config if needed. - last update
over 1 year ago 36 pass - Status changed to Needs work
over 1 year ago 5:59am 27 August 2023 - 🇸🇮Slovenia bcizej
There seems to be a problem with the
/list
endpoint (or maybe it's designed that way I don't know) but if you specify multipleaccountkeys
in the header it only retrieves pages from the first account key. I used a test account with multiple workspaces and it returned only pages from the first account key that was in the header. When switching the order of account keys (before they are json encoded and base64 encoded) I would get pages from a different workspace but again only from that workspace. - last update
over 1 year ago 15 pass, 2 fail Had to fix how data is read in
getPageList
. Currently looking at fixing the API tests, to correctly mock new responses.- last update
over 1 year ago run-tests.sh fatal error - last update
over 1 year ago 36 pass - Status changed to Needs review
over 1 year ago 8:32am 29 August 2023 Now all pages are listed. Experimenting with Instapage, they changed how /list page works, their implementation only displays pages for selected workspace.
- Status changed to RTBC
over 1 year ago 8:21am 5 September 2023 - 🇸🇮Slovenia deaom
If you have multiple work spaces which have sub pages added, they are now displayed in the page select when all work spaces are first selected. If you switch workspace, then only pages from that workspace are available. Would say this now works, so marking it as RTBC.
- last update
over 1 year ago 36 pass -
bcizej →
committed 2aa641ca on 3.x authored by
admirlju →
Issue #3264831 by admirlju, bcizej, DeaOm, colema18: Choose Instapage...
-
bcizej →
committed 2aa641ca on 3.x authored by
admirlju →
- Status changed to Fixed
over 1 year ago 2:59pm 10 September 2023 Automatically closed - issue fixed for 2 weeks with no activity.