Search API cache plugins cause errors when the index is disabled. The error we see in logs is:
Error: Call to a member function preExecute() on null in Drupal\search_api\Plugin\views\cache\SearchApiTagCache->generateResultsKey()
May be related to 🐛 Call to a member function preExecute() on null in SearchApiTagCache->alterCacheMetadata() Fixed .
Cache plugins shouldn't access Search API query in case the view query is in an invalid state.
Submit MR/patch.
Needs work
1.0
Views integration
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Thanks for reporting this problem and already providing a patch!
I just added a single additional shouldAbort() check – see the attached patch and please test/review.
Also: Do we really want to cache an aborted query? Shouldn’t cacheSet() just return in case $query->shouldAbort() is TRUE?
Finally, I think we should add a regression test for this before committing, to make sure this stays fixed. A WSoD is a rather nasty thing to run into, after all.