- 🇦🇹Austria drunken monkey Vienna, Austria
Thanks for reporting this problem and already providing a patch!
I just added a single additional
shouldAbort()
check – see the attached patch and please test/review.Also: Do we really want to cache an aborted query? Shouldn’t
cacheSet()
just return in case$query->shouldAbort()
isTRUE
?Finally, I think we should add a regression test for this before committing, to make sure this stays fixed. A WSoD is a rather nasty thing to run into, after all.
- 🇬🇧United Kingdom Rob230
Re-rolling patch for 1.38.
I'm wondering if the last part of the patch is still needed since the module has a null check on
getSearchApiQuery()
. But regardless of that, I assume it still needs to checkshouldAbort()
.