path_delete() creates empty aliases when no path found

Created on 9 February 2022, over 2 years ago

Updated 2 March 2023, over 1 year ago

Problem/Motivation

Unlike core path_delete(), if the criteria to CPS's path_delete() do not match an existing path, it will create a new alias row with source and alias both empty. A simple

if (!$path) {
  return;
}

should handle this.

🐛 Bug report

Status

Active

Version

1.0

Component

Code

Created by

🇺🇸United States mikeryan Murphysboro, IL, USA

Live updates comments and jobs are added and updated live.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇮🇹Italy marco
It is actually expected from cps_url_alias to create an empty alias. It's how an alias is flagged to be deleted in a site version.
Then during publishing the aliases are deleted, and the empty ones are not re-created: https://git.drupalcode.org/project/cps/-/blob/7.x-1.x/modules/cps_path/c...
Comment about 1 year ago →
🇮🇹Italy marco
But there's currently a bug, and in some cases the empty alias is written for the live alias.
The attached patch should fix the issue.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024