Fix handling of removed notification plugin dependencies

Created on 7 February 2022, almost 3 years ago
Updated 21 January 2024, 11 months ago

On review of the module code, I spotted that $updated_config in SavedSearchType::onDependencyRemoval() is never read, pointing to a definitive bug. (We don’t save the updated configuration for notification plugins that removed a dependency.)
Also, as we copied the code from Search API indexes, which have multiple types of plugins, we use $plugin_type in several places where it is unnecessary. (It is still necessary in the basic dependency data array, to distinguish between dependencies of plugins and dependencies of the type entity itself.)

Anyways, in addition to fixing that code, this definitely needs code coverage, too.

πŸ› Bug report
Status

Fixed

Version

1.0

Component

Code

Created by

πŸ‡¦πŸ‡ΉAustria drunken monkey Vienna, Austria

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024