Record type menu items lose translations

Reopening this... it appears that it was not fixed after all. See this new GitHub issue thread: https://github.com/farmOS/farmOS/issues/626

We may be encountering this core issue: 🐛 Block/menu/views derivative labels are always shown in the first language they are view in after cache rebuild Needs work .

Attached is a patch that demonstrates a relatively simple "hotfix" for this, which can be implemented in farmOS OR in a custom module, if someone needs it. It is *not* the right solution to this issue, which seems to be an upstream Drupal core issue at heart.

Notably, this approach only solves the issue caused by running drush cr. However, if a Drupal admin user has a non-default language (eg: German), and clears the caches via /admin/config/development/performance, then another user with a different non-default language (eg: Norwegian) will see the menu items in the language that the admin user who cleared the cache uses (German). I think the reason this approach works for Drush, but not for that case, is because Drush runs as the default language. But I don't know that for sure.

Updated the issue description's steps to reproduce to include more of the information I've learned in recent testing.