- π§π¬Bulgaria pfrenssen Sofia
Reviewed, the fix looks good, but I wouldn't add additional documentation explaining that the line needs to be at the top. That context is only useful for people looking at this particular issue, but for future readers of the code this is not useful at all.
Setting this to minor since this seems to be a false positive from the PHPCompatibility library. The
$hook_base
variable isn't changed by reference in the preceding lines, but there's no way that PHPCompatibility can know that for sure in procedural function calls, so it reports this.It would be good to get this fix in anyway to make the warning go away.
- Status changed to Needs review
about 1 year ago 1:39pm 20 September 2023 - π³π΄Norway steinmb
Quick update of this one liner. It it quiet the assumed false positive, lets get it in.
- πΊπΈUnited States dasginganinja Bethlehem, PA
How is this not in yet?