PHP 7.3 compatibility issue

Created on 31 January 2022, almost 3 years ago
Updated 12 December 2023, about 1 year ago

FILE: /test/toolkit/dist/modules/contrib/wysiwyg/wysiwyg.module
----------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
----------------------------------------------------------------------
1779 | WARNING | Since PHP 7.0, functions inspecting arguments, like
| | func_get_args(), no longer report the original
| | value as passed to a parameter, but will instead
| | provide the current value. The parameter
| | "$hook_base" was used, and possibly changed (by
| | reference), on line 1773.
----------------------------------------------------------------------

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

πŸ‡§πŸ‡ͺBelgium Serotonine

Live updates comments and jobs are added and updated live.
  • PHP 7.3

    The issue particularly affects sites running on PHP version 7.3.0 or later.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡§πŸ‡¬Bulgaria pfrenssen Sofia

    Reviewed, the fix looks good, but I wouldn't add additional documentation explaining that the line needs to be at the top. That context is only useful for people looking at this particular issue, but for future readers of the code this is not useful at all.

    Setting this to minor since this seems to be a false positive from the PHPCompatibility library. The $hook_base variable isn't changed by reference in the preceding lines, but there's no way that PHPCompatibility can know that for sure in procedural function calls, so it reports this.

    It would be good to get this fix in anyway to make the warning go away.

  • Status changed to Needs review about 1 year ago
  • πŸ‡³πŸ‡΄Norway steinmb

    Quick update of this one liner. It it quiet the assumed false positive, lets get it in.

  • πŸ‡ΊπŸ‡ΈUnited States dasginganinja Bethlehem, PA

    How is this not in yet?

Production build 0.71.5 2024