hook_simplenews_subscribe fires before subscription

We have a new 4.x in alpha, so it's a good time to look at this again

We could fire the hook in postSave() with code roughly like this.

if ($this->isConfirmed() && isset($this->original) {
  // Compare subscriptions of new and old.
  $added = ...
  $removed = ...

  foreach ($added as $newsletter_id) {
    \Drupal::moduleHandler()->invokeAll('simplenews_subscribe', [$this, $newsletter_id]);
  }

  foreach ($removed as $newsletter_id) {
    \Drupal::moduleHandler()->invokeAll('simplenews_unsubscribe', [$this, $newsletter_id]);
  }

Does that sound good?

Yeah, looks good.

I've attached patches (based on AdamPS's snippet above) for simplenews 3.x and 4.x.

Thanks @smokris

1) Actually my comment #8 wasn't quite right. I think we need like this:

if (isset($this->original) && $this->original->isConfirmed()) {
  $original = $this->original->getSubscribedNewsletterIds();
}
else {
  $original = [];
}

2) Let's create a variable for the current ones too so we don't calculate them twice:

$current = $this->getSubscribedNewsletterIds();

3) Plus a variable for the result of \Drupal::moduleHandler() so we don't calculate it many times.

4) It would be great to have a test for the hooks. But if you don't want to, it's still useful to fix the other comments😃.

Reroll of #10

Automatically closed - issue fixed for 2 weeks with no activity.