Add types to function parameters

I like passing 'create' because it's much more informative to the reader than just TRUE.

What we can do is to add types to the function arguments. This would then force conversion to bool.

> What we can do is to add types to the function arguments. This would then force conversion to bool.

That's now how types work. Types don't convert automatically, that will give you a fatal error.

I like passing 'create' because it's much more informative to the reader than just TRUE.

So let's used string or mixed in the interface, rather than violating our own interface. Someone swapping out the Subscriber class could get bitten if they believed what the interface said.

I realise it's a little strange that I pass strings like this for bool - I'm content to give it up. Here's a patch that adds types to SubscriberInterface - let's see what happens.

The last submitted patch, 6: simplenews.param-types.3260400-6.patch, failed testing. View results →
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

That's now how types work. Types don't convert automatically, that will give you a fatal error.

It seems there are some specific exceptions where types do convert automatically. See https://www.php.net/manual/en/language.types.type-juggling.php#language.....

In this context the value must be a value of the type. Two exceptions exist, the first one is: if the value is of type int and the declared type is float, then the integer is converted to a floating point number. The second one is: if the declared type is a scalar type, the value is convertable to a scalar type, and the coercive typing mode is active (the default), the value may be converted to an accepted scalar value. See below for a description of this behaviour.

Automatically closed - issue fixed for 2 weeks with no activity.

Follow-up: 🐛 Subscriber::loadByMail(): Argument #1 ($mail) must be of type string, null given Needs review