Contrib.social

Page not displaying (404 error shown)

Open on Drupal.org →
Created on 5 January 2022, over 2 years ago
Updated 9 September 2023, 10 months ago

Problem/Motivation

It seems last committed patch #3248340: Can not add a new landing page → , broke the Drupal functionality of displaying the "landing page" in Drupal, as it always returns 404. The issue seems to be with the URL, which is not correct.

Steps to reproduce

1. Create a landing page in instapage then push it to Drupal.
2. On the Drupal side under admin/structure/instapage add new page and create a link
3. Visit that link. You should get the 404 error.

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇸🇮Slovenia DeaOm

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 10 months ago
    36 pass
  • Status changed to Needs review 10 months ago
  • Comment 10 months ago →
    🇸🇮Slovenia DeaOm

    Since there was some other work done regarding requests, I revisited this issue, to see what's happening. It seems GET requests are not allowed as the GET request will always return a 404 error. Rebased the branch with the new changes and tested again, it seems the correction is not needed anymore as page is displayed normally/as expected. I did change how the data from request is retrieved, to use actual Drupal request instead of the PHP server one, so marking it as needs review. The 404 response is however now a guzzle one as the exception thrown is from guzzle.

  • Status changed to RTBC 10 months ago
  • Comment 10 months ago →
    admirlju

    The change works fine and the tests are passing, marking this as RTBC.

  • First commit to issue fork.
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 7.4 & MySQL 5.7
    last update 10 months ago
    36 pass
  • Comment 10 months ago →
    System Message
    • bcizej → committed ea62e88d on 3.0.x authored by DeaOm → 
      Issue #3257042 by DeaOm, gombi, admirlju: Page not displaying (404 error...
  • Status changed to Fixed 10 months ago
  • Comment 10 months ago →
    🇸🇮Slovenia bcizej

    Merged, thanks.

  • Comment 9 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024