Unique on number fields migrated as "false" makes unique required

Created on 16 December 2021, almost 3 years ago

Updated 13 April 2024, 8 months ago

When number fields migrate, $extra['unique'] gets set to the string "true" or the string "false".

Webform evaluates either the string "true" or "false" as a positive, so even though my yml generated by the migration says '#unique': false, when I try to use the form the field must be unique.

A way to fix this is to set unique to NULL rather than the string "false" for a non-unique field.

Tested with Webform 6.1.2 on Drupal 9.3.0.

🐛 Bug report

Status

Needs review

Version

2.0

Component

Code

Created by

🇨🇦Canada floydm

Live updates comments and jobs are added and updated live.

Incomplete comments

Merge Requests

!34Unique on number fields migrated as "false" makes unique required
Open
🇹🇼Taiwan g-brodiei
updated 8 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

First commit to issue fork.
Status changed to Needs review 8 months ago3:26am 13 April 2024
Comment 8 months ago →
🇹🇼Taiwan g-brodiei
Confirmed this happens on webform_migration for 2.0.x and Drupal 10.2.5

Settings form element from '#unique: false' to '#unique: NULL' resolves this webform unique issue.

Set the branch target to 2.0.x-dev

Provides MR and update patch for 2.0.x-dev that resolves this bug, set back to NR.
Merge request !34fix 3254854-Unique on number fields migrated as false makes unique required → (Open) created by g-brodiei

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024

Unique on number fields migrated as "false" makes unique required

Merge Requests

!34Unique on number fields migrated as "false" makes unique requiredOpen

Comments & Activities

!34Unique on number fields migrated as "false" makes unique required
Open