discourse_sync assumes Discourse username will be Drupal account name, but that's not always the case

Created on 16 December 2021, over 3 years ago
Updated 13 September 2023, over 1 year ago

discourse_sso allows admins to choose any text field to be the username (which is also the foreign key) of the linked discourse user.

If the choice is any other than the default, discourse_sync doesn't work at all.

discourse_sync should use the immutable external_id property (drupal account id) to lookup Discourse user accounts.
https://meta.discourse.org/t/find-a-user-by-their-identity-provider-exte...

πŸ› Bug report
Status

Needs work

Version

2.0

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States AaronBauman Philadelphia

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • πŸ‡§πŸ‡ͺBelgium kristiaanvandeneynde Antwerp, Belgium

    Update the MR a bit to pass around what's already on the event. Removed two methods and merged them into one.

    Normally, the changes here would be a no-go because they break backwards compatibility, but I highly doubt anyone was calling the sync service themselves manually. Also, this module has no tests, so any change is a shot in the dark, really.

  • Status changed to Needs work over 1 year ago
  • πŸ‡¬πŸ‡§United Kingdom joachim

    Left some comments on the MR. I think I may have spotted another place where this assumption is being made.

Production build 0.71.5 2024