Existing Contact can have validation error when filtered by group

Hey folks,

This is still an issue actually. I had a heck of a time trying to figure out where the stacktrace issue was coming from. Is there any reason we can't use a different variable than group. I think it's a useful function but presently I can't use it for a client because of this issue.

Warning: explode() expects parameter 2 to be string, array given in Drupal\Core\Form\FormErrorHandler->setElementErrorsFromFormState()

Confirmed for a D9 + php8.1 install.

For my example, there are a number of "existing contact" fields, some of which are filtered by group, and it appears that the ones that break are those that are not filtered by group (but maybe that's because that's as far as it gets ...).

I also notice that the group looks like this:

[#group] => Array
(
[] =>
)

The code is actually happy to skip the field if it's empty, but that's an array with a single empty entry, so the array itself isn't empty.

Conclusions:
1. It might work to just slightly fix how that #group value is being generated, and remove any empty group.
2. In the meantime, you can just patch your drupal core with something like this:

diff --git web/core/lib/Drupal/Core/Form/FormErrorHandler.php web/core/lib/Drupal/Core/Form/FormErrorHandler.php
index dfb52c072e..eabda5c87e 100644
--- web/core/lib/Drupal/Core/Form/FormErrorHandler.php
+++ web/core/lib/Drupal/Core/Form/FormErrorHandler.php
@@ -147,7 +147,7 @@ protected function setElementErrorsFromFormState(array &$form, FormStateInterfac
 
         // If this direct child belongs to a group populate the grouping element
         // with the children errors.
-        if (!empty($child['#group'])) {
+        if (!empty($child['#group']) && is_string($child['#group'])) {
           $parents = explode('][', $child['#group']);
           $group_element = NestedArray::getValue($form, $parents);
           if (isset($group_element['#children_errors'])) {

@adixon Actually in my case it really had to do with the group being set.

We have a webform like the following

+ Existing Contact - Contact name
+ Existing Contact Household - Contact name filtered by Group

If I set this as empty it's just fine, and when I traced it it seems like the #group is a reserved name used already thus causing this error. Maybe I'm wrong here though.

For sure, the source of the issue is that '#group' is used for the drupal group concept, and there's validation that assumes it's a string.

My patch might work for you, in that by the time the form gets to that level of validation, it probably doesn't need to care about #group.

On the other hand, your experience suggests that fixing this might be trickier than I thought or hoped.

Ultimately, the '#group' property that webform civicrm uses really needs a different key so that we're not colliding with the drupal '#group'.

I believe there's some work being done in that direction.

I've raised a PR here https://github.com/colemanw/webform_civicrm/pull/928

Can we please test this in detail with drush updb execution on existing webforms?

Thanks.

Oh how I wish I had found this a few days ago... I spent hours trying to track it down and I thought it was to do with a Webform Validation Handler I had written. https://civicrm.stackexchange.com/questions/48120/custom-webform-handler....

It makes no difference whether the filter uses Autocomplete - we pass in Contact IDs and its static at the beggining, it is purely the #group, even 'None'.