new_relic_rpm no longer sets route name for dynamically defined routes

Created on 6 December 2021, almost 3 years ago
Updated 21 February 2023, over 1 year ago

Problem/Motivation

The new version does support some more advanced callbacks and does set the route name as a parameter on the route, but that does mean that some routes are missing that information then.

For example, we're seeing that problem with all routes defined by page_manager, because those are defined after \Drupal\new_relic_rpm\EventSubscriber\RoutingTransactionNameSubscriber::addTransactionNamesToRoutes() runs.

Steps to reproduce

Proposed resolution

Add back a fallback to \Drupal\new_relic_rpm\RouteEnhancer\TransactionNameEnhancer(), if no _transaction_name is defined, set it then?

Alternatively, the event priority could also be adjusted to run very late and catch all routes except those that somehow set an even lower priority.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs review

Version

2.0

Component

Code

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024