Cache clear required after fathom_analytics settings are updated

Created on 29 November 2021, over 2 years ago
Updated 7 February 2024, 5 months ago

Problem/Motivation

First, thanks for the excellent module. It made integrating with Fathom Analytics a breeze.

But I noticed when I updated the settings to exclude admins from getting the script, I had to clear cache before the script was removed.

Proposed resolution

We can add cache tags to the page so the cache is invalidated when fathom_analytics settings are updated.

This same kind of thing is done in the google_analytics module. See here: https://git.drupalcode.org/project/google_analytics/-/blob/4.x/google_an...

I don't think that code is readable. I'm going to propose a different syntax.

MR to follow. Thanks!

Remaining tasks

MR/patch
Review

User interface changes

None

API changes

None

Data model changes

None

🐛 Bug report
Status

Fixed

Version

3.0

Component

Code

Created by

🇺🇸United States danflanagan8 St. Louis, US

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024