The method Drupal\Core\Database\Driver\mysql\Connection::__construct() cannot be called without the second parameter being set.

Created test and rerolled old code changes.
I submitted 2 patches, one with only the test file where the test will fail and another patch with the actual fix where the test succeeds.
Please review.

After review on local-machine from daffie i have made some changes and also have fixed the corrupt patch that failed to apply.

The last submitted patch, 25: 3251084-25-test-only-should-fail.patch, failed testing. View results →

Both the fix and the added test look good to me.
For me it is RTBC.

Looks like we still need this follow-up suggested by @alexpott:

Also we should file a follow-up to remove 'ANSI_QUOTES' it is pointless - it is covered by 'ANSI' and our default sql_mode is "SET sql_mode = 'ANSI,TRADITIONAL'"

Also we should file a follow-up to remove 'ANSI_QUOTES' it is pointless - it is covered by 'ANSI' and our default sql_mode is "SET sql_mode = 'ANSI,TRADITIONAL'"

I think that will be fixed in #3261236: ANSI and TRADITIONAL SQL mode implementations vary between mysql and mariadb → .

Ahh thanks for finding the existing issue.

Committed 1b7265e and pushed to 10.1.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.